Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vale linter #241

Merged
merged 9 commits into from
Oct 22, 2024
Merged

Fix Vale linter #241

merged 9 commits into from
Oct 22, 2024

Conversation

RCheesley
Copy link
Member

@RCheesley RCheesley commented Oct 22, 2024

The Vale linter isn't working properly, I supect because the GitHub Action is quite out of date.

This PR updates the versions of actions/checkout and also switches to errata-ai/vale-action@reviewdog.

In the process, had to move the customised vocab directory to support the breaking changes in Vale 3.0 per https://vale.sh/docs/topics/vocab/#folder-structure.

Basically synchronising with the current user-docs + trying to fix the failing GitHub Action linter.

@RCheesley
Copy link
Member Author

A bit baffled how to install docutils / rst2html as adding to the requirements.txt doesn't seem to be working. I'm a bit out of my depth, raised an issue errata-ai/vale#915 hoping someone can point out the obvious!

@RCheesley RCheesley marked this pull request as ready for review October 22, 2024 01:17
@RCheesley RCheesley changed the title WIP fix Vale linter Fix Vale linter Oct 22, 2024
@RCheesley RCheesley added bug Something isn't working hacktoberfest-accepted labels Oct 22, 2024
@RCheesley
Copy link
Member Author

Am going to merge this because there's a large backlog to get through and this linter is pretty central to doing that effectively for us as reviewers, and for the contributors to get the right feedback in a timely way.

@RCheesley RCheesley merged commit 23fd2ad into mautic:main Oct 22, 2024
2 checks passed
@RCheesley RCheesley deleted the fix-vale-prose-linter branch October 22, 2024 01:28
Copy link

holopin-bot bot commented Oct 22, 2024

Congratulations @RCheesley, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm2jrotpk28340cl1g7jatbyv

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant